Skip to content
This repository was archived by the owner on Feb 4, 2023. It is now read-only.

Conversation

@fvarrui
Copy link
Contributor

@fvarrui fvarrui commented Jun 30, 2020

Please check if the PullRequest fulfills these requirements:

(Add x between brackets to check.)

  • I’ve updated my fork from the develop branch before proposing this pull request
  • I’m making this pull request against the develop branch
  • I’ve tested the changes for bug fixes and/or features
  • I’ve documented new code

What kind of change does this PR introduce? (Bug fix, feature, docs update, other)

Added spanish localization.

What is the current behavior? (You can also link to an open issue here)

Not spanish language supported.

What is the new behavior?

Now it shows messages in spanish.

Does this PR introduce a breaking change? (What changes might users need to make in their application / PList file due to this PR?)

No

Other information:

@fvarrui
Copy link
Contributor Author

fvarrui commented Jun 30, 2020

Hi @tofi86! I submitted a PR. I take the opportunity to thank you for this amazing script! I'm using it in my JavaPackager Maven Plugin.

@tofi86
Copy link
Owner

tofi86 commented Jun 30, 2020

Awesome! 🎉 Thanks for your contribution! 👏

Glad you like the script!

@tofi86 tofi86 merged commit ed8c848 into tofi86:develop Jun 30, 2020
@tofi86 tofi86 added this to the Version 3.0.7 milestone Jun 30, 2020
@tofi86 tofi86 added the i18n label Jun 30, 2020
@tofi86 tofi86 self-assigned this Jun 30, 2020
Copy link
Owner

@tofi86 tofi86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@fvarrui
Copy link
Contributor Author

fvarrui commented Jun 30, 2020

Great! 😃

@tofi86 tofi86 mentioned this pull request Jan 7, 2021
@tofi86
Copy link
Owner

tofi86 commented Jan 7, 2021

Version 3.1.0 has officially been released 🎉

Details: https://github.com/tofi86/universalJavaApplicationStub/releases/tag/v3.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants