i18n: restore {username} in unbannedUserFromCommunity (es, it, sk) - #2128
Open
owgreen-dev wants to merge 1 commit into
Open
owgreen-dev wants to merge 1 commit into
owgreen-dev wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
unbannedUserFromCommunityines,itandskdropped the{username}placeholder, so the snackbar can't say who was unbanned. Restored it in each, keeping the existing wording:app_es.arbUsuario no expulsado de la comunidadSe anuló la expulsión de {username} de la comunidadapp_it.arbSbanna Utente dalla ComunitàSbannato {username} dalla comunitàapp_sk.arbOdblokovaný používateľ z komunityOdblokovaný používateľ {username} z komunity3 files, 3 lines; the
@unbannedUserFromCommunityplaceholder metadata already declaresusername, soflutter gen-l10npicks it up unchanged. (Not touched on purpose: the{count, plural, …}strings that several locales simplified to a single word — that's a plural-fidelity choice, not a broken variable.)Found with an open-source i18n placeholder checker I maintain (shipi18n); each string checked by hand against
app_en.arb. Full scan for this repo: https://shipi18n.com/oss#thunderIssue Being Fixed
Issue Number: N/A
Screenshots / Recordings
n/a — string-only change.
Checklist
semanticLabels where applicable for accessibility? — n/a