Skip to content

README updates and CI fixes - #403

Merged
cretz merged 2 commits into
temporalio:mainfrom
cretz:gevent-readme
Oct 24, 2023
Merged

cretz merged 2 commits into
temporalio:mainfrom
cretz:gevent-readme

Conversation

@cretz

@cretz cretz commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

What was changed

  • Document that there's a gevent sample
  • Document that time-skipping test server doesn't work on ARM

Checklist

  1. Closes Investigate issues with gevent.monkey.patch_all() #59
  2. Closes Document that time skipping test server does not currently work on ARM #379

@cretz
cretz requested a review from a team as a code owner October 20, 2023 12:51

@dandavison dandavison left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread README.md Resolved
@cretz

cretz commented Oct 23, 2023

Copy link
Copy Markdown
Contributor Author

I am moving this to draft while I work on the CI problem

@cretz
cretz marked this pull request as draft October 23, 2023 19:18
@cretz cretz changed the title README updates README updates and CI fixes Oct 23, 2023
@cretz
cretz force-pushed the gevent-readme branch 2 times, most recently from 772278c to 8beeaf1 Compare October 24, 2023 12:53
@cretz
cretz marked this pull request as ready for review October 24, 2023 13:20
@cretz

cretz commented Oct 24, 2023

Copy link
Copy Markdown
Contributor Author

CI fixed. Merging.

@cretz
cretz merged commit 4242dfb into temporalio:main Oct 24, 2023
@cretz
cretz deleted the gevent-readme branch October 24, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document that time skipping test server does not currently work on ARM Investigate issues with gevent.monkey.patch_all()

3 participants