Skip to content

Provide the namespace to external storage drivers - #2119

Merged
jmaeagle99 merged 4 commits into
mainfrom
extstore-ambient-namespace
Nov 18, 2026
Merged

jmaeagle99 merged 4 commits into
mainfrom
extstore-ambient-namespace

Conversation

@jmaeagle99

Copy link
Copy Markdown
Contributor

What was changed

  • Added an optional namespace to StorageDriverStoreContext and StorageDriverSelectContext, set to the namespace of the client or worker performing the operation.
  • S3 and GCS drivers use it when there is no target: keys are now v0/ns/{namespace}/d/sha256/{hash} (null when unknown) instead of v0/d/sha256/{hash}. The long-key fallback keeps the namespace segment too.

Why?

  • Payloads stored without a target (schedule memos, headers, task-token completions and heartbeats, Nexus) now land under a namespace prefix, so per-namespace bucket policies and lifecycle rules cover everything a namespace writes.
  • Drivers and selectors can route or scope by namespace without a target.

Checklist

  1. How was this tested: Unit tests for the drivers and contexts, plus a worker end-to-end test.

  2. Any docs updates needed? S3 and GCS driver READMEs updated.

@jmaeagle99
jmaeagle99 requested a review from a team as a code owner November 12, 2026 20:14
Comment thread temporalio/client/_schedule.py Resolved
@jmaeagle99 jmaeagle99 changed the title Pass the namespace to external storage drivers Provide the namespace to external storage drivers Nov 13, 2026
@VegetarianOrc VegetarianOrc self-assigned this Nov 18, 2026
Comment thread temporalio/client/_impl.py Resolved
@jmaeagle99
jmaeagle99 enabled auto-merge (squash) November 18, 2026 04:53
@jmaeagle99
jmaeagle99 merged commit d8d594b into main Nov 18, 2026
47 of 52 checks passed
@jmaeagle99
jmaeagle99 deleted the extstore-ambient-namespace branch November 18, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants