Skip to content

fix(extstore): report wall-clock duration for storage metrics - #1815

Merged
jmaeagle99 merged 2 commits into
mainfrom
storage-duration
Sep 9, 2026
Merged

jmaeagle99 merged 2 commits into
mainfrom
storage-duration

Conversation

@jmaeagle99

Copy link
Copy Markdown
Contributor

What was changed

Fix external storage duration metrics to measure wall-clock time instead of sum of each driver call.

Why?

More accurately reflect the wall-clock time spent on storage operations in a workflow task.

Checklist

  1. Closes [Bug] External storage transfer stats reports summation of durations instead of wall-clock duration #1562

  2. How was this tested: Unit tests

  3. Any docs updates needed? No

@jmaeagle99
jmaeagle99 requested a review from a team as a code owner September 4, 2026 00:15
@jmaeagle99
jmaeagle99 enabled auto-merge (squash) September 8, 2026 19:01
@jmaeagle99
jmaeagle99 merged commit 8e1ff10 into main Sep 9, 2026
114 of 124 checks passed
@jmaeagle99
jmaeagle99 deleted the storage-duration branch September 9, 2026 15:53
patbeqo added a commit to temporalio/skill-temporal-observability that referenced this pull request Nov 15, 2026
…ings (#16)

Adds a Worker Log Signals section to troubleshooting.md covering Core
console log format, the [TMPRL1104] slow-task warning, autoscaling
poll-error warnings and Python log forwarding lifetime.

Operators parsing worker logs or alerting on slow tasks need the formats
and the threshold setting.

Upstream:
- temporalio/sdk-rust#1433
- temporalio/sdk-rust#1485
- temporalio/sdk-rust#1500
- temporalio/sdk-go#2658
- temporalio/sdk-go#2697
- temporalio/sdk-python#1749
- temporalio/sdk-python#1750
- temporalio/sdk-python#1815
- https://github.com/temporalio/sdk-python/releases/tag/1.32.0
- https://github.com/temporalio/sdk-python/releases/tag/1.33.0
- temporalio/sdk-python#1998
- temporalio/sdk-ruby#538
- https://github.com/temporalio/sdk-ruby/releases/tag/v1.10.0
- temporalio/sdk-typescript#2314

Eval: Knowledge task, Claude Code, Sonnet 5.5
Baseline: 7/7 items, 615k tokens, 112s
Improved: 7/7 items, 75k tokens, 19s
Delta: +0 items, -88% tokens, -83% time

Eval task: temporalio/skill-evals#429

---------

Co-authored-by: temporal-plugin-updater[bot] <3389934+temporal-plugin-updater[bot]@users.noreply.github.com>
Co-authored-by: Patrik Beqo <patbeqo@gmail.com>
Co-authored-by: temporal-plugin-updater[bot] <276371939+temporal-plugin-updater[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] External storage transfer stats reports summation of durations instead of wall-clock duration

2 participants