Repository navigation
Use native Nexus serialization context for async sample results - #815
Open
litlep-nibbyt wants to merge 7 commits into
Open
litlep-nibbyt wants to merge 7 commits into
litlep-nibbyt wants to merge 7 commits into
Conversation
litlep-nibbyt
commented
Nov 11, 2026
| @@ -0,0 +1,175 @@ | |||
| package io.temporal.samples.nexusserializationcontext; | |||
Contributor
Author
There was a problem hiding this comment.
this seems a bit tedious and possibly flaky need to reassess whether its worth keeping
litlep-nibbyt
commented
Nov 11, 2026
| () -> handlerA.fromPayload(requestB, String.class, String.class)); | ||
| } | ||
|
|
||
| @Test |
Contributor
Author
There was a problem hiding this comment.
this seemed unnecessary because it tests the old workaround
litlep-nibbyt
marked this pull request as ready for review
November 12, 2026 20:30
| Use a Temporal Server that supports Nexus serialization-context propagation for | ||
| workflow-backed asynchronous operations. For local development, download | ||
| [Temporal CLI `v1.9.3-nexus-serialization-context`](https://github.com/temporalio/cli/releases/tag/v1.9.3-nexus-serialization-context) | ||
| and add its `temporal` binary to your `PATH`. Its dev server includes this support. |
Contributor
There was a problem hiding this comment.
Can we avoid telling users to put this prerelease CLI on their PATH? It replaces their stable temporal with a build that embeds an unreleased server from main.
Contributor
|
Can also update this sample to show CompressedEncryptedHandlerWorker and EncryptedHandlerWorker using more than one key, and picking which to use based on the Nexus Endpoint? This is now possible async and sync operations |
Serve two endpoints per handler with distinct keys in one namespace. Keep sync and async calls explicit, simplify the sample codec tests, and remove the dev-server integration test.
Name endpoints, keys, task queues, and results by their encoding chain. Use a dedicated caller workflow key while retaining the four endpoint keys and their existing secret values. Update the README and codec tests.
Keep each handler in its own namespace using descriptive encoding names. Update local setup commands, the namespace table, and caller test context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the per-endpoint encryption sample to use SDK-provided Nexus serialization context for workflow-backed async results, replacing the custom interceptor and workflow-header propagation workaround.
Expand the sample from two endpoints to four, adding one endpoint and a second key to each handler. Each endpoint uses a distinct AES-GCM key. The compressed/encrypted handler applies zlib before encryption; the other handler encrypts without compression. The caller and each handler use separate, descriptively named namespaces. A dedicated caller workflow key protects its ordinary input and final result independently of the four endpoint keys.
Keep the eight sync/async calls and result fields explicit. Update the README’s endpoint/key mappings and local setup, keeping the prerelease CLI separate from the stable installation. Keep codec tests focused on sample configuration.
Validation:
11cc5743and CLIv1.9.3-nexus-serialization-context.