fix(cmake): add CMAKE_INSTALL_LIBDIR for ext_gtest to fix lib64 path …

[boxiaobj]

…on aarch64

On CentOS 7 aarch64, GNUInstallDirs defaults to lib64, causing ext_gtest to install libraries to lib64/ while CMake expects lib/. This is consistent with how other ExternalProject targets already handle this (e.g. ext_libuv, ext_snappy, ext_rocksdb, etc.).

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a build and installation inconsistency for the ext_gtest external project on aarch64 systems, specifically CentOS 7. By explicitly defining the library installation directory, it ensures that ext_gtest libraries are placed in the expected lib/ directory, aligning its behavior with other external dependencies and preventing potential runtime issues caused by incorrect library paths.

Highlights

• Fix ext_gtest installation path: Corrected the installation path for ext_gtest libraries on CentOS 7 aarch64 by explicitly setting CMAKE_INSTALL_LIBDIR to lib, resolving an issue where libraries were incorrectly installed to lib64/.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• cmake/external.cmake
  • Added CMAKE_INSTALL_LIBDIR argument for ext_gtest to ensure correct library installation path.

Activity

• No activity has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a build issue on aarch64 for the ext_gtest external project by explicitly setting CMAKE_INSTALL_LIBDIR to lib. This ensures the library installation path is consistent with what's expected in the build configuration. The change is consistent with how other external projects are handled in this file.

While this change is correct, a broader opportunity exists to apply this fix to other external projects in cmake/external.cmake. Several other targets, such as ext_zlib and ext_jansson, also have hardcoded lib/ paths but do not set CMAKE_INSTALL_LIBDIR. They might suffer from the same issue on platforms like aarch64. It would be beneficial to audit and apply this fix to all such targets for improved build robustness across different architectures.