Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the documentation for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the testcase-authoring skill documentation by splitting it into a concise SKILL.md entry file and a detailed REFERENCE.md. This change aligns with best practices for progressive disclosure and makes the skill easier to consume for the AI agent. The new REFERENCE.md provides comprehensive and clear guidelines for writing test cases. I have one minor suggestion to improve the consistency of a code example within the reference document.
There was a problem hiding this comment.
Pull request overview
This PR restructures the “testcase-authoring” documentation skill by splitting it into a short entry-point “SKILL” file and a more detailed “REFERENCE” file, while also updating docs CI filtering to avoid running on .claude/** Markdown changes.
Changes:
- Add
.claude/skills/testcase-authoring/SKILL.mdas a lightweight entry file pointing to the reference. - Add
.claude/skills/testcase-authoring/REFERENCE.mdwith detailed, actionable testcase authoring guidance. - Update docs CI workflow to exclude
.claude/**from trigger paths and Markdown changed-file detection; add.autocorrectrcfor AutoCorrect configuration.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/tdengine-docs-ci.yml | Excludes .claude/** from docs CI trigger paths and from Markdown changed-file detection. |
| .claude/skills/testcase-authoring/SKILL.md | New lightweight skill entry file referencing the detailed guide. |
| .claude/skills/testcase-authoring/REFERENCE.md | New detailed reference guide for testcase authoring patterns and pitfalls. |
| .autocorrectrc | New AutoCorrect configuration (includes/excludes and rule toggles). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -11,6 +11,7 @@ on: | |||
| - 'docs/**' | |||
| - '.github/workflows/tdengine-docs-ci.yml' | |||
There was a problem hiding this comment.
The workflow is now skipping .claude/** Markdown changes (good), but changes to the new .autocorrectrc file itself won’t trigger this docs CI because it’s neither under docs/** nor **/*.md. If .autocorrectrc controls AutoCorrect behavior for docs, consider adding .autocorrectrc to the on.pull_request.paths list so config changes get validated by CI.
| - '.github/workflows/tdengine-docs-ci.yml' | |
| - '.github/workflows/tdengine-docs-ci.yml' | |
| - '.autocorrectrc' |
split testcase authoring skill into a lightweight entry file and a detailed reference file