fix(xnode): force show xnode task clause order by id

[acerDebugman]

Closes 6856696160

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where "SHOW XNODE" statements might return results in an inconsistent order. By programmatically injecting an "ORDER BY id ASC" clause into the query parsing logic, all "SHOW XNODE" commands will now consistently present their output sorted by the entity's unique identifier. This change improves data presentation reliability and user experience, ensuring that Xnode tasks, agents, and jobs are always displayed in a predictable sequence.

Highlights

• Xnode Query Ordering: Implemented a default "ORDER BY id ASC" clause for "SHOW XNODE" statements (tasks, agents, jobs) to ensure consistent and predictable result ordering.
• Test Coverage: Added a new comprehensive test case to verify that "SHOW XNODE TASKS", "SHOW XNODE AGENTS", and "SHOW XNODE JOBS" commands correctly return results sorted by their "id" in ascending order.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• source/libs/parser/src/parTranslater.c
  • Injected logic to automatically add an "ORDER BY id ASC" clause to "SHOW XNODE" queries.
  • Handled error conditions during node creation and list appending for the order by clause.
• test/cases/42-Xnode/test_xnode.py
  • Added "test_show_xnode_order_by_id" function to verify ascending "id" order for "SHOW XNODE TASKS", "AGENTS", and "JOBS".
  • Included setup and teardown logic to create and clean up test Xnode entities.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly adds an ORDER BY id clause to SHOW XNODE... statements to ensure a consistent output order, and includes a comprehensive test case for tasks, agents, and jobs. However, there are a couple of areas for improvement. The new code block in parTranslater.c has complex nested logic for error handling which could be simplified for better readability and maintainability. More importantly, the change also affects SHOW XNODES, but this is not covered by tests, posing a risk of regression if the underlying table lacks an id column. I've left a detailed comment with a suggested refactoring and a note on the potential regression.