fix(ext window): shrink ext window mem when loop finished

[stephenkgu]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link
  https://project.feishu.cn/taosdata_td/defect/detail/6617556609

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @stephenkgu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a memory management issue within the external window operator. It specifically improves how and when memory associated with external window results is deallocated, ensuring that memory is freed appropriately once an operation concludes, particularly in scenarios involving stream processing. This change aims to enhance the stability and resource efficiency of the system.

Highlights

• Memory Deallocation: Refined the memory deallocation logic for external window operations to ensure resources are freed correctly upon completion.
• Conditional Memory Freeing: Introduced a conditional check to free external window result rows only when the operation is complete and stream runtime information is present, preventing potential memory leaks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to optimize memory usage in the external window operator by shrinking memory when a loop is finished. The change moves the memory freeing logic for aggregation mode to be called when the operator is marked as done. However, the new logic makes this call conditional on pStreamRuntimeInfo, which could lead to memory not being freed in non-stream contexts for aggregation mode. I've suggested making the call unconditional to prevent this potential issue and to make the behavior consistent across different operator modes.