enh: drop multi-stream

[Pengrongkun]

Description

https://project.feishu.cn/taosdata_td/feature/detail/6491072341

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @Pengrongkun, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the DROP STREAM SQL command, allowing users to drop multiple streams in a single statement. This improves the command's utility and efficiency by streamlining the process of managing multiple stream processing tasks. The changes span across the SQL parser, internal data models, message serialization, and the core stream management logic, ensuring robust and consistent behavior. Comprehensive documentation updates and a new test case validate the new functionality.

Highlights

• Multi-Stream Drop Support: The DROP STREAM SQL command now supports dropping multiple streams simultaneously by specifying a comma-separated list of stream names.
• Internal Data Structure Updates: The SMDropStreamReq and SDropStreamStmt internal structures have been modified to accommodate a list of stream names, replacing the previous single-stream name fields.
• Serialization and Deserialization Logic: The serialization and deserialization functions (tSerializeSMDropStreamReq, tDeserializeSMDropStreamReq) have been updated to correctly handle the new array-based stream name structure for network communication.
• Stream Processing Logic Enhancement: The mndProcessDropStreamReq function in the stream processing module has been refactored to iterate through and process each stream in the provided list for dropping, including privilege checks and TSMA-related stream handling.
• Documentation and Testing: Both English and Chinese documentation for the DROP STREAM command have been updated to reflect the new syntax, and a new Python test case has been added to validate the multi-stream drop functionality across different databases.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the DROP STREAM command to allow dropping multiple streams at once. The changes span documentation, data structures, serialization, parsing, and server-side logic. The implementation is mostly correct, but I've found several critical memory leaks and a compilation error in the parser translation logic due to improper error handling and resource cleanup. Additionally, there are some minor issues in the mnode logic, including a behavioral change for DROP STREAM IF EXISTS and a redundant function call. A new test file is added to cover the new functionality, which is great.