Skip to content

Add spam validation check in auth email templates #30188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

joshenlim
Copy link
Member

@joshenlim joshenlim commented Oct 30, 2024

Related API PR: https://github.com/supabase/infrastructure/pull/20234

Adds a spam validation check in the auth email templates page. We're using SpamAssassin for the check

  • Show risk of spam if > 1 spam rule with score > 0 is returned
  • Prevent saving if > 1 spam rule with score > 0 is returned while using built in email service

Validation check happens on 2 events

  • Debounce after 1s when editing content
  • When going between templates

Example spam detected:
image

Example spam not detected:
image

@joshenlim joshenlim requested a review from a team as a code owner October 30, 2024 08:59
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 3:33pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:33pm
studio ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:33pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 3:33pm
docs ⬜️ Skipped (Inspect) Oct 30, 2024 3:33pm
zone-www-dot-com ⬜️ Skipped (Inspect) Oct 30, 2024 3:33pm

Copy link

supabase bot commented Oct 30, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com October 30, 2024 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 30, 2024 15:27 Inactive
@joshenlim joshenlim merged commit db2e977 into master Oct 31, 2024
16 checks passed
@joshenlim joshenlim deleted the chore/add-email-spam-validation-check branch October 31, 2024 02:07
zackproser-workos pushed a commit to zackproser-workos/supabase that referenced this pull request Nov 13, 2024
* Add spam validation check in auth email templates

* Update comment

* Add another banding

* Update
encima pushed a commit that referenced this pull request Nov 19, 2024
* Add spam validation check in auth email templates

* Update comment

* Add another banding

* Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants