Skip to content

chore: aggressive prefetching #29987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 24, 2024
Merged

chore: aggressive prefetching #29987

merged 19 commits into from
Oct 24, 2024

Conversation

alaister
Copy link
Member

No description provided.

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 0:54am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 0:54am
studio ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 0:54am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 0:54am
docs ⬜️ Skipped (Inspect) Oct 24, 2024 0:54am
zone-www-dot-com ⬜️ Skipped (Inspect) Oct 24, 2024 0:54am

Copy link

supabase bot commented Oct 18, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com October 19, 2024 10:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 19, 2024 10:14 Inactive
@alaister alaister marked this pull request as ready for review October 19, 2024 10:17
@alaister alaister requested a review from a team as a code owner October 19, 2024 10:17
@vercel vercel bot temporarily deployed to Preview – docs October 24, 2024 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com October 24, 2024 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 24, 2024 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com October 24, 2024 08:21 Inactive
Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on preview that perceived loading speed around the table editor is improved, although we need to check on one thing though that the call to /views seems to be triggered each time i hover over a table link in the table editor

Copy link
Member

@joshenlim joshenlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once again! Tested the prefetching logic in table editor and also checking that the table def query doesnt error out with a foreign table!

@vercel vercel bot temporarily deployed to Preview – docs October 24, 2024 12:48 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com October 24, 2024 12:48 Inactive
@alaister alaister merged commit 5781937 into master Oct 24, 2024
14 checks passed
@alaister alaister deleted the chore/aggressive-prefetching branch October 24, 2024 12:59
encima pushed a commit that referenced this pull request Nov 19, 2024
* chore: aggressive prefetching

* use abort signals in prefetchers

* move encrypted columns to react-query

* prefetching for filter and sort applied

* prefetch remaining entity types

* prefetch tables in more places

* prefetch editor page on project panel

* add feature flag

* fix typescript

* nit

* Nit

* fix imports

* remove views check on encrypted schemas

* use fetchQuery instead of prefetchQuery

* fix useEncryptedColumnsQuery ts error

* filter by schema on encrypted columns

* don't use pg_get_tabledef for foreign tables

* Remove unnecesary import

---------

Co-authored-by: Joshen Lim <joshenlimek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants