Skip to content

Chore/user management v2 panel #29468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Sep 25, 2024
Merged

Conversation

joshenlim
Copy link
Member

Clicking on a user will open the user's information up in a panel

  • All actions previously behind a context menu is now available here (and context menu is removed as well)

image

@joshenlim joshenlim requested a review from a team as a code owner September 24, 2024 08:01
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 1:46pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 1:46pm
studio ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 1:46pm
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 1:46pm
docs ⬜️ Skipped (Inspect) Sep 24, 2024 1:46pm
zone-www-dot-com ⬜️ Skipped (Inspect) Sep 24, 2024 1:46pm

Copy link

supabase bot commented Sep 24, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@vercel vercel bot temporarily deployed to Preview – docs September 24, 2024 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com September 24, 2024 08:09 Inactive
@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com September 24, 2024 09:43 Inactive
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview with email and github based users

couple of tiny nits:

@saltcod
Copy link
Contributor

saltcod commented Sep 24, 2024

Not blocking & this affects a bunch of newer data grids, but up/down keyboard nav would be great through the rows, and hitting Esc should close the side panel

screenshot-2024-09-24-at-09 32 03

@saltcod
Copy link
Contributor

saltcod commented Sep 24, 2024

this "waiting for notification" message
used to be in further to the left — its now only visible if you scroll.
Seems like an important piece of info to be always visible — wonder can we move that column over? (just imo, feel free to disagree)
screenshot-2024-09-24-at-09 34 30

@saltcod
Copy link
Contributor

saltcod commented Sep 24, 2024

can also tackle this separately, but curious where the pending state is for search

it's currently down at the bottom, out of view on long tables
screenshot-2024-09-24-at-09 41 38

@saltcod
Copy link
Contributor

saltcod commented Sep 24, 2024

I feel like these two sidebar areas would benefit from a heading to make consistent with the others. Not sure the word "Actions" is right though. "Resend / reset" maybe?

screenshot-2024-09-24-at-09 52 26

@joshenlim
Copy link
Member Author

joshenlim commented Sep 24, 2024

this "waiting for notification" message
used to be in further to the left — its now only visible if you scroll.

hmm thinking about this - i reckon the best solution here is eventually to make the table columns sortable (and persisted via local storage), every team has their own preferred order of the columns i think, will look into this subsequently. And also maybe allow the users to hide certain columns (e.g if im mainly using phone auth, i wouldn't really need the email column)

pending state is for search

Added the loading line! 🙏

I feel like these two sidebar areas would benefit from a heading to make consistent with the others. Not sure the word "Actions" is right though. "Resend / reset" maybe?

Tbh i was thinking of just shifting the data under "Invite information" to the first section - not sure if there's added benefit keeping it separated. Also thinking of adding separators - so we've got 3 sections (1) User info + provider (2) actions (3) danger, cause i can't think of a good title/description for (2) either (the UI itself feels quite clear what they are)

@vercel vercel bot temporarily deployed to Preview – zone-www-dot-com September 24, 2024 13:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs September 24, 2024 13:42 Inactive
@joshenlim joshenlim merged commit 6af9ff6 into master Sep 25, 2024
14 checks passed
@joshenlim joshenlim deleted the chore/user-management-v2-panel branch September 25, 2024 04:40
encima pushed a commit that referenced this pull request Nov 19, 2024
* Midway implementing user management v2 panel

* Do up overview panel less provider information

* Midway provider info

* Wrap up provider information

* Add banned until banner

* Slight adjustment to search input

* Fix

* Fix provider icons in data grid

* Fix

* Moar fixes

* Add loading line

* Address some feedback

* Reorder some elements in the user overview panel

* Fix icons going over cell headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants