Skip to content

Autofocus table editor search input #29446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2024
Merged

Autofocus table editor search input #29446

merged 1 commit into from
Sep 23, 2024

Conversation

joshenlim
Copy link
Member

No description provided.

@joshenlim joshenlim requested a review from a team as a code owner September 23, 2024 06:23
@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
studio-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 6:29am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
design-system ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 6:29am
studio ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 6:29am
studio-self-hosted ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 6:29am
docs ⬜️ Skipped (Inspect) Sep 23, 2024 6:29am
zone-www-dot-com ⬜️ Skipped (Inspect) Sep 23, 2024 6:29am

@supabase Supabase
Copy link

supabase bot commented Sep 23, 2024

No changes detected in supabase directory.
This pull request has been ignored for the connected project xguihxuzqibwxjnimxev due to its connection settings.
Go to Project Integrations Settings ↗︎ in order to change this behavior.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@notion-workspace Notion Workspace
Copy link

When opening the Table Editor, by far the most common next action is to open a table. Please focus (set the cursor into) the search field, so I can start typing the table name instantly. Even if people who have few tables prefer to use mouse (with or without scrolling the table list first), focusing the search field won't interfere with this. Google does similar thing with their search....

alaister
alaister approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Tested on preview

@joshenlim joshenlim merged commit 2ad5675 into master Sep 23, 2024
15 checks passed
@joshenlim joshenlim deleted the chore/autofocus-table-editor-search-input branch September 23, 2024 08:01
encima pushed a commit that referenced this pull request Nov 19, 2024
@joshenlim @encima
Autofocus table editor search input (#29446)
cdc60ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaister alaister alaister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshenlim @alaister