Skip to content

Add stale bot #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add stale bot #422

merged 1 commit into from
Apr 30, 2024

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Add stale bot to mark issues and PRs as Stale after a long period of inactivity.
  • Currently, it does NOT close issues automatically, but it can do so if wanted.
  • Same yaml as Add stale bot supabase-py#774

Additional context

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juancarlospaco - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

- uses: actions/stale@v9
with:
days-before-pr-stale: 365
days-before-pr-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting 'days-before-pr-close' to -1 may prevent PRs from ever being auto-closed.

Consider setting a positive number of days after which a stale PR should be closed to ensure the repository remains clean.

Suggested change
days-before-pr-close: -1
days-before-pr-close: 30

days-before-pr-stale: 365
days-before-pr-close: -1
days-before-issue-stale: 365
days-before-issue-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting 'days-before-issue-close' to -1 may prevent issues from ever being auto-closed.

It might be beneficial to define a specific timeframe after which stale issues are closed to maintain a manageable issue tracker.

Suggested change
days-before-issue-close: -1
days-before-issue-close: 30

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (b858685) to head (02a849c).
Report is 26 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
+ Coverage   95.72%   95.91%   +0.18%     
==========================================
  Files          28       28              
  Lines        1639     1715      +76     
==========================================
+ Hits         1569     1645      +76     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 merged commit 44f3672 into supabase:master Apr 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants