Skip to content

Follow redirects #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Follow redirects #511

merged 7 commits into from
Jun 4, 2024

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Add follow_redirects=True.
  • All other Supabase libs follow redirects by default.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.38%. Comparing base (e3862b9) to head (4a18e21).
Report is 36 commits behind head on main.

Files Patch % Lines
supabase_auth/_sync/api.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #511   +/-   ##
=======================================
  Coverage   44.38%   44.38%           
=======================================
  Files          23       23           
  Lines        2032     2032           
=======================================
  Hits          902      902           
  Misses       1130     1130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@silentworks silentworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR missing a change in _async/api.py since there is one in _sync/api.py?

@silentworks
Copy link
Contributor

Ignore previous comment since we only have _sync/api.py due to BC.

@silentworks silentworks merged commit 1fa7fd2 into supabase:main Jun 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants