feat: add C implementation for math/base/special/besselj0#2774
Merged
Conversation
gunjjoshi
commented
Aug 11, 2024
gunjjoshi
commented
Aug 11, 2024
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
kgryte
changed the title
math/base/special/besselj0math/base/special/besselj0
kgryte
changed the title
math/base/special/besselj0math/base/special/besselj0
Planeshifter
approved these changes
Aug 11, 2024
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
One comment; overall looks good to me!
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com>
gunjjoshi
added a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2774 Ref: stdlib-js#649 --------- Signed-off-by: Gunj Joshi <gunjjoshi8372@gmail.com> Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Reviewed-by: Athan Reines <kgryte@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
math/base/special/besselj0.Related Issues
This pull request:
Questions
No.
Other
Checklist
@stdlib-js/reviewers