fix(config): migrate another telemetry config #3328
Merged
+480
−70
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3267
This PR adds another migration to finish migrating the other instance of the
telemetry.Configin the runtime config.Details
The original fix for the bug only migrated the
telemetry_configfield in the runtime config. However, it's also possible fortelemetry.Configto exist in theruntimeConfig.middleware_configs[i].parameters.configas seen below:{ "middleware_configs": [ { "type": "telemetry", "parameters": { "config": { "endpoint": "", "serviceName": "toolhive-mcp-proxy", "serviceVersion": "v0.6.13", "tracingEnabled": true, "metricsEnabled": true, "samplingRate": 1, "headers": {}, "insecure": true, "enablePrometheusMetricsPath": true, "environmentVariables": [ "USER", "HOST" ] }, "server_name": "mermaid", "transport": "streamable-http" } } ] }How was this missed?
The
parametersfield is an untyped json blob.Changes
telemetry_configand themiddleware_configs.middleware_configsis migrated in the event users have already upgradedmiddleware_configsaccording to the structure above.