feat(debug): Add databases=managed debug option#2898
Merged
kyleconroy merged 3 commits intomainfrom Oct 23, 2023
Merged
Conversation
Collaborator
kyleconroy
commented
Oct 20, 2023
kyleconroy
commented
- Remove the --no-database flag
- Refactor the shfmt package
- Remove the --no-database flag - Refactor the shfmt package
andrewmbenton
requested changes
Oct 21, 2023
| @@ -448,14 +448,7 @@ func (c *checker) fetchDatabaseUri(ctx context.Context, s config.SQL) (string, f | |||
| } | |||
|
|
|||
| func (c *checker) DSN(dsn string) (string, error) { | |||
Collaborator
There was a problem hiding this comment.
Don't really need this func anymore
Collaborator
Author
There was a problem hiding this comment.
Agreed, but it was easier to keep it around
Co-authored-by: Andrew Benton <andrew@sqlc.dev>
Co-authored-by: Andrew Benton <andrew@sqlc.dev>
andrewmbenton
approved these changes
Oct 21, 2023
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
* feat(debug): Add databases=managed debug option - Remove the --no-database flag - Refactor the shfmt package --------- Co-authored-by: Andrew Benton <andrew@sqlc.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.