Repository navigation
fix: require MonetaryAmount properties - #3361
Merged
bnasslahsen merged 1 commit intoOct 23, 2026
Merged
Conversation
Mark amount and currency as required because the JSR 354 supplier contracts guarantee both values are non-null. Update the OpenAPI 3.0 and 3.1 fixtures accordingly. Co-Authored-By: Codex GPT-5 <noreply@openai.com>
bnasslahsen
added a commit
that referenced
this pull request
Oct 23, 2026
See gh-3361 Signed-off-by: Badr NASS LAHSEN <badr.nasslahsen@gmail.com>
bnasslahsen
added a commit
that referenced
this pull request
Oct 23, 2026
See gh-3361 Signed-off-by: Badr NASS LAHSEN <badr.nasslahsen@gmail.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSR 354 currency and number supplier contracts guarantee non-null values, but SpringDoc’s replacement model currently describes both properties as optional. Mark
amountandcurrencyas required and update the OpenAPI 3.0 and 3.1 fixtures accordingly.