Skip to content

make known falsy when unknown medium is determined - #7

Open
Marco Fernandes (marcospiridon) wants to merge 1 commit into
snowplow-referer-parser:masterfrom
marcospiridon:Make-known-falsy-when-medium-unkown-is-determined
Open

Marco Fernandes (marcospiridon) wants to merge 1 commit into
snowplow-referer-parser:masterfrom
marcospiridon:Make-known-falsy-when-medium-unkown-is-determined

Conversation

@marcospiridon

Copy link
Copy Markdown

Noticed that known attribute was always true even if the referrer domain was not present in the data json file.
This fix sets known to False when medium unknown is determined

@github-actions github-actions Bot added the cla:requested Asked the contributor to sign the CLA label Oct 29, 2026
@gthomson31 Greg Thomson (gthomson31) removed the cla:requested Asked the contributor to sign the CLA label Oct 29, 2026
@github-actions github-actions Bot added the cla:requested Asked the contributor to sign the CLA label Oct 29, 2026
@github-actions

Copy link
Copy Markdown
Snowplow

Thanks for your contribution, Marco Fernandes (@marcospiridon)! 👋

Before we can review this pull request, we need you to sign the Snowplow Contributor License Agreement (CLA). It only takes a minute, and you only need to do it once.

Once you've signed, reply here (e.g. "I've signed the CLA") and a maintainer will pick up your review.

This is an automated message. Find out more about the CLA here. If you've already signed, you can ignore this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:requested Asked the contributor to sign the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants