Skip to content

fix(sql-schema): stop generating a duplicate "id" column #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertoabellagarcia merged 1 commit into from
Sep 23, 2026
Merged

fix(sql-schema): stop generating a duplicate "id" column #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions pysmartdatamodels/pysmartdatamodels/pysmartdatamodels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1177,6 +1177,16 @@ def generate_sql_schema(model_yaml: str) -> str:
table_create_statement = f"CREATE TABLE {entity} ("

for key, value in model_yaml[entity]["properties"].items():
# "id" always maps to the primary key column, regardless of what
# "type"/"format"/etc. it declares -- handle it here and move on, so
# it isn't *also* appended by the type-mapping branches below (that
# produced a duplicate "id" column in every generated schema, since
# id properties almost always declare a "type").
if key == "id":
field_type = "TEXT PRIMARY KEY"
sql_schema_statements.append(f"\"{key}\" {field_type}")
continue

field_type = "JSON" # Default to JSON if type is not defined

# Field type mapping
Expand Down Expand Up @@ -1226,11 +1236,6 @@ def generate_sql_schema(model_yaml: str) -> str:
sub_field_type = type_mapping.get(sub_value["type"])
sql_schema_statements.append(f"\"{sub_key}\" {sub_field_type}")

if key == "id":
field_type = "TEXT PRIMARY KEY"
# add attribute to the SQL schema statement
sql_schema_statements.append(f"\"{key}\" {field_type}")

# Complete the CREATE TABLE statement
table_create_statement += ", ".join(sql_schema_statements)
table_create_statement += ");"
Expand Down