Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
+ Coverage 83.68% 83.86% +0.17%
==========================================
Files 115 115
Lines 12905 13049 +144
==========================================
+ Hits 10800 10943 +143
- Misses 2105 2106 +1 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Nice work working on this 💯
Would it be simple to add integration tests in integration_tests/web for these endpoints?
zimeg
left a comment
There was a problem hiding this comment.
@srtaalej Thanks so much for bringing these methods to the SDK! 🧰 ✨
I'm finding good responses from the server when using these changes so am hoping we can merge this soon, but also left comments around typing that I think are worth consideration.
Overall I'm hoping we can improve our models here in the SDK to expect the various list item schemas, similar to Block Kit. This might not be a blocker for python releases, but we might require such for java and I do think we should aim to keep SDKs aligned in featureset when possible!
Lots of rambles. Please let me know if the other comments seem alright! 👾
| @@ -15,7 +15,7 @@ | |||
| class TestWebClientCoverage(unittest.TestCase): | |||
| # 295 endpoints as of September 17, 2025 | |||
There was a problem hiding this comment.
🏷️ note: We should update this as well!
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
Co-authored-by: Eden Zimbelman <eden.zimbelman@salesforce.com>
slack_sdk/web/async_client.py
Outdated
|
|
||
| from ..models.attachments import Attachment | ||
| from ..models.blocks import Block, RichTextBlock | ||
| from ..models.metadata import Metadata |
There was a problem hiding this comment.
Looks like the tests are flagging these duplicate imports
|
Related: slackapi/bolt-python#1401 |
Summary
This PR adds the following
slackListsmethods to theslack_sdk:access.delete,access.set,create,download.get,download.start,items.create,items.delete,items.deleteMultiple,items.info,items.list,items.update,updateTesting
Category
Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.