Fix #1592 by encoding aiohttp client session pings#1593
Fix #1592 by encoding aiohttp client session pings#1593seratch merged 1 commit intoslackapi:mainfrom jasonwbarnett:jwb/fix-ping
Conversation
|
Thanks for the contribution! Before we can merge this, we need @jasonwbarnett to sign the Salesforce Inc. Contributor License Agreement. |
|
I've already signed the CLA
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 113 113
Lines 12622 12622
=======================================
Hits 10719 10719
Misses 1903 1903 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
seratch
left a comment
There was a problem hiding this comment.
Thank you so much for taking the time to send this PR. Looks great to me; once the CI jobs pass, we will merge it and cut a new patch release.
|
@seratch thanks for releasing this change so quickly. I've deployed this to production and confirmed it's working as expected now. |
Summary
Fixes #1592
Testing
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.