Fix warnings for renmaed methods and unsupported test methods#36
Open
kdubb wants to merge 3 commits intosideeffect-io:mainfrom
Open
Fix warnings for renmaed methods and unsupported test methods#36kdubb wants to merge 3 commits intosideeffect-io:mainfrom
kdubb wants to merge 3 commits intosideeffect-io:mainfrom
Conversation
project: bump CHANGELOG to 0.5.2
## Code * Updates all old signature `withTaskCancellationHandler` methods. Requires is a simple reordering of the closure parameters. The “new” signature is already used in the code so shouldn’t have an impact on platform/swift version support. ## Tests * Repalces all `await wait(for:timeout:)` and `waitForExpectations` with `await fulfillment(of:timeout:)` The current use of `await wait(for:timeout:)` and `waitForExpectations(timeout:)` has been deprecated in async test methods due to a possibility of deadlocking the test (see https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3-release-notes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code
withTaskCancellationHandlermethods. Requires is a simple reordering of the closure parameters.The “new” signature is already used in the code so shouldn’t have an impact on platform/swift version support.
Tests
await wait(for:timeout:)andwaitForExpectationswithawait fulfillment(of:timeout:)The current use of
await wait(for:timeout:)andwaitForExpectations(timeout:)has been deprecated in async test methods due to a possibility of deadlocking the test (see https://developer.apple.com/documentation/xcode-release-notes/xcode-14_3-release-notes)Description
Checklist