fix: sf nodes extend price calculation

[sigmachirality]

Fixes sf nodes extend command showing 10x inflated prices by correcting quote API parameters and price calculation logic.

The previous implementation incorrectly passed quantity: 8 (GPUs per node) to the quote API's quantity parameter (number of nodes), inflating each quote by 8x. Additionally, the multi-node total summed raw quote prices, which included an extra hour for duration flexibility, leading to a further ~1.25x overestimation. These compounded to a ~10x error.

---

Slack Thread

  

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
src/lib/nodes/extend.ts	24% smaller
src/helpers/test/quote.test.ts	0% smaller

[indent]

PR Summary

Fixes the sf nodes extend confirmation total, which displayed ~10× the actual extend cost for multi-node extends. Two stacking bugs caused the inflation: each per-node getQuote was called with quantity: 8 (the API param means nodes, not GPUs/node), and the multi-node total summed raw quote prices that included the quote's flexible duration window (+1h slack). After this PR the displayed estimate matches what the backend extend call will actually charge, and partial-liquidity cases are explicitly surfaced to the user.

• src/lib/nodes/extend.ts: change per-node getQuote(quantity: 8) to quantity: 1 so each quote represents one node.
• src/lib/nodes/extend.ts: rewrite the multi-node total to sum per-node-hour rates (via getPricePerGpuHourFromQuote * GPUS_PER_NODE / 100) and multiply by the user's requested duration, mirroring the single-node display path. Uses .toFixed(2) for consistency with the per-node-hr branch.
• src/lib/nodes/extend.ts: when some per-node quotes return null (no liquidity), append (estimate covers N of M nodes; remaining nodes will extend up to --max-price) so the displayed total isn't silently understated when the extend loop still attempts every node.
• src/helpers/test/quote.test.ts: new vitest coverage for getPricePerGpuHourFromQuote quantity-invariance, the corrected multi-node total, duration-flexibility safety, and a documenting test for the historical ~10× bug shape.

Issues

All clear! No issues remaining. 🎉

2 issues already resolved

• totalEstimate.toFixed(0) rounds the multi-node total to whole dollars, dropping cents the old totalPrice / 100 would have printed (e.g. a $76.80 estimate now reads ~$77); reasonable for an "~$" preview, but confirm this precision loss is intentional. (fixed by commit 61cb8e5)
• Null-valued quotes silently understate the multi-node total: getQuote can resolve to null (no liquidity for that node), and those fulfilled-but-null entries are skipped by the new reducer, while the extend loop still attempts every node up to --max-price — so partial-capacity scenarios will display a price for fewer nodes than the user actually pays for. Triggers whenever any per-node quote returns null. (fixed by commit 61cb8e5)

CI Checks

All CI checks pass for commit 61cb8e5.

[capy-ai]

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.