Skip to content

(docs) Correct spelling errors and remove unfinished sentence. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanmcdermott merged 1 commit into from
Jan 5, 2017
Merged

(docs) Correct spelling errors and remove unfinished sentence. #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,7 @@ function writeForumComment(subject, body) {

**Good**:
```javascript
function writeForumComment(subject='No subject', body='No text') {
function writeForumComment(subject = 'No subject', body = 'No text') {
...
}

Expand Down Expand Up @@ -790,7 +790,7 @@ The first thing to consider is consistent APIs.
**Bad:**
```javascript
function travelToTexas(vehicle) {
if (obj instanceof Bicylce) {
if (obj instanceof Bicycle) {
vehicle.peddle(this.currentLocation, new Location('texas'));
} else if (obj instanceof Car) {
vehicle.drive(this.currentLocation, new Location('texas'));
Expand Down Expand Up @@ -897,7 +897,7 @@ inventoryTracker('apples', req, 'www.inventory-awesome.io');
### Use getters and setters
JavaScript doesn't have interfaces or types so it is very hard to enforce this
pattern, because we don't have keywords like `public` and `private`. As it is,
using getters and setters to access data on objects if far better than simply
using getters and setters to access data on objects is far better than simply
looking for a property on an object. "Why?" you might ask. Well, here's an
unorganized list of reasons why:

Expand Down Expand Up @@ -1558,7 +1558,7 @@ you should prefer composition over inheritance where you can. There are lots of
good reasons to use inheritance and lots of good reasons to use composition.
The main point for this maxim is that if your mind instinctively goes for
inheritance, try to think if composition could model your problem better. In some
cases it can. Inheritance is great for preventing
cases it can.

You might be wondering then, "when should I use inheritance?" It
depends on your problem at hand, but this is a decent list of when inheritance
Expand Down