Build complete usable type from a type-relative prefix #14586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looking for angle brackets in the source code, use the HIR and Ty interfaces to either copy the original type, or complete it with `_` placeholders if all type and const generic arguments are inferred.
rustbot
added
the
S-waiting-on-review
blyxyas
approved these changes
Apr 17, 2025
| let mut ty_str = itertools::join(ty_path.segments.iter().map(|s| s.ident), "::"); | ||
| let mut first = true; | ||
| let mut append = |arg: &str| { | ||
| write!(&mut ty_str, "{}{arg}", [", ", "<"][usize::from(first)]).unwrap(); |
There was a problem hiding this comment.
Really smart way to determine if we should use a comma or not!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking for angle brackets in the source code, use the HIR and Ty interfaces to either copy the original type, or complete it with
_placeholders if all type and const generic arguments are inferred.Fixes #14581
changelog: [
from_iter_instead_of_collect]: show correct type in suggestion