Repository navigation
Use rb_econv_memsize for econv_memsize - #18389
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Encoding::Converter’s typed-data memory accounting so it reflects the full rb_econv_t footprint (including internal buffers/transcodings) by delegating to rb_econv_memsize.
Changes:
- Switch
econv_memsizefrom a fixedsizeof(rb_econv_t)torb_econv_memsize(...)for accurate accounting.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
econv_memsize only counted the rb_econv_t struct, but it should use rb_econv_memsize.
peterzhu2118
force-pushed
the
econv-memsize
branch
from
August 19, 2026 12:43
f82afb4 to
5557bf7
Compare
jhawthorn
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
econv_memsize only counted the rb_econv_t struct, but it should use rb_econv_memsize.