Merged
Conversation
uberhacker
reviewed
Jan 10, 2023
uberhacker
reviewed
Jan 10, 2023
supechicken
reviewed
Jan 11, 2023
satmandu
requested review from
supechicken and
uberhacker
and removed request for
supechicken and
uberhacker
supechicken
reviewed
Jan 11, 2023
uberhacker
reviewed
Jan 11, 2023
Contributor
Author
|
Is this acceptable @hsbt ? |
Member
|
Thanks for your work. At least, We need to the additional tests. Can you add them? |
Contributor
Author
What are the additional needed tests? |
Contributor
Author
|
@hsbt What additional tests are needed? |
Member
|
for your changes. |
Contributor
Author
|
Ah! I will modify https://github.com/ruby/fileutils/blob/master/test/fileutils/test_fileutils.rb ... |
Contributor
Author
|
Does this work? |
Member
|
I'll fix this CI fails. It's not related with your tests. |
Contributor
Author
|
@hsbt Any chance of this getting merged? |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 10, 2023
(ruby/fileutils#104) * Add mkdir_p to FileUtils.install * Adjust raise message. * adjust raise language * handle trailing slash in dest * simplify * Add tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
mkdir_pon the destination directory solves that issue.