Skip to content

Conversation

@pjain1
Copy link
Member

@pjain1 pjain1 commented Dec 30, 2025

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add a test for it using the Druid test connector in resolvers/testdata/metrics_summary.yaml?

@pjain1 pjain1 merged commit b6fca84 into main Jan 5, 2026
13 of 14 checks passed
@pjain1 pjain1 deleted the mv_summary_druid branch January 5, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants