Forward compatibility with stream 1.0, 0.7, 0.6, and 0.5#2
Merged
WyriHaximus merged 3 commits intoreactphp:masterfrom May 14, 2017
Merged
Conversation
clue
approved these changes
May 13, 2017
Member
|
FWIW: This does not affect BC, so we may as well release this as v0.1.1 👍 |
Member
Author
I was anticipating more breaking to be honest 🤓, 0.1.1 makes sense to me, what about you @jsor? |
kelunik
suggested changes
May 14, 2017
| "require": { | ||
| "php": ">=5.3", | ||
| "react/stream": "^0.4 || ^0.3", | ||
| "react/stream": "^1.0 || ^0.7 || ^0.6 || ^0.5 || ^0.4 || ^0.3", |
Contributor
There was a problem hiding this comment.
I wouldn't include 1.0 here, as 1.0 isn't released yet. Changes could happen that are not planned yet.
Member
Author
There was a problem hiding this comment.
Anything between 0.7 and 1.0 will be bug fixes. Nothing major will change
jsor
approved these changes
May 14, 2017
Member
|
I'm good with either. |
Member
Author
|
Will tag |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned on the roadmap in #1, support the latest stream tags as well.