feat: Add codemod to transform string refs to arrow-functions#309
Open
eps1lon wants to merge 1 commit intoreactjs:masterfrom
Open
feat: Add codemod to transform string refs to arrow-functions#309eps1lon wants to merge 1 commit intoreactjs:masterfrom
eps1lon wants to merge 1 commit intoreactjs:masterfrom
Conversation
1 task
Member
Author
|
We decided against a codemdoddable warning |
Member
Author
|
The plan is to land unfreezing |
46cadc4 to
5376b3b
Compare
5376b3b to
63feb87
Compare
noahlemen
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-string-refs-and-remove-production-mode-_owner-field
In:
<div ref="refComponent" />;Out:
Note that this codemod only works for React 18.3 or higher.
Should not be used if the codebase contains warnings about string refs without owners e.g.
Test plan
yarn testnode bin/react-codemod.js string-refs ~/repos/react