Repository navigation
Conversation
facebook-github-bot
added
GH Review: review-needed
CLA Signed
Contributor
|
@ericvicenti, @ide: Any idea if this will cause problems? The previous code with the comment was pretty clear.... |
Contributor
|
@ide: just mark as accepted when you think this is good to go and I'll import it. |
Contributor
|
Reading through, this won't cause correctness issues I believe but it may affect performance. Will need to dig in deeper since I'm not very familiar with this code. |
Contributor
Author
|
Performance is important, but 'm sure we can't afford loosing navbar on pop(). |
|
+1 I've noticed this bug recently too. |
Contributor
|
@jaysalvat updated the pull request. |
Collaborator
|
@facebook-github-bot shipit |
Contributor
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/972167456166907/int_phab to review. |
ghost
closed this
in
FalseLobster
pushed a commit
to FalseLobster/react-native
that referenced
this pull request
Dec 19, 2023
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Summary: Pull Request resolved: #58720 Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally. - .flowconfig: builtin_lib=flowlib-with-lib-dom-d-ts - Delete copied DOM libdefs flow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.js - flow-typed/environment/node.js: use globalThis.Blob; drop an unused suppression - Restore suppressions needed under lib.dom.d.ts Console (index-test.js, resolver-test.js, logToConsole.js) and drop ones now unused - HMRClient-test.js: mock WebSocket via jest.spyOn(global, 'WebSocket', 'get') instead of writing the readonly global Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122152628
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 28, 2026
Summary: Internal and OSS Flow disagreed on DOM builtins, so suppressions removed in #1965 were unused in OSS but needed internally. - .flowconfig: builtin_lib=flowlib-with-lib-dom-d-ts - Delete copied DOM libdefs flow-typed/environment/{bom,dom,cssom,serviceworkers,streams}.js - flow-typed/environment/node.js: use globalThis.Blob; drop an unused suppression - Restore suppressions needed under lib.dom.d.ts Console (index-test.js, resolver-test.js, logToConsole.js) and drop ones now unused - HMRClient-test.js: mock WebSocket via jest.spyOn(global, 'WebSocket', 'get') instead of writing the readonly global Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122152628
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Summary: Applies the metro #1989 node.js change (resolveObjectURL returns globalThis.Blob) to the React Native mirror copy, and re-enables flow-defs-sync-test (un-skips the parent diff). Changelog: [Internal] Differential Revision: D122321586
meta-codesync Bot
pushed a commit
that referenced
this pull request
Sep 29, 2026
Summary: Pull Request resolved: #58733 Applies the metro #1989 node.js change (resolveObjectURL returns globalThis.Blob) to the React Native mirror copy, and re-enables flow-defs-sync-test (un-skips the parent diff). Changelog: [Internal] Reviewed By: cortinico Differential Revision: D122321586 fbshipit-source-id: ddbb9c94e3a67df5545e79c5b583bf1632fe7a94
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using nativator.pop() the navigatorBar doesn't refresh properly if we change navigationBarHidden.
Current result:
When navigator.pop() is called, the navbar doesn't show up, even avec navigationBarHidden set back to true. See between Statusbar and Movie poster in the example below.
https://github.com/facebook/react-native/blob/master/Libraries/Components/Navigation/NavigatorIOS.ios.js#L510-L512
Expected result (after fix)
The View need to be refreshed in pop method anyway.
Now, navbar appears properly.