Repository navigation
Update the flags needed for Android compatiblity - #1191
Merged
Merged
Conversation
Added a platform check so that the flags will only be set if the OS being run is Android, as they aren't needed for iOS. Also changed the original "&&" structure for a simple "if" structure, since the original would incur on a "no-unused-expressions" error on default ESLint configurations. Said error can be overridden by allowing the "allowShortCircuit" option on .eslintrc, but since current guidelines don't recommend it, such cases should be avoided as much as possible, hence the change.
|
Deploy preview for react-native ready! Built with commit b99f712 https://deploy-preview-1191--react-native.netlify.com Changes to Thank you for your contributions. |
charpeni
approved these changes
Aug 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a platform check so that the flags will only be set if the OS being run is Android, as they aren't needed for iOS.
Also changed the original "&&" structure for a simple "if" structure, since the original would incur on a "no-unused-expressions" error on default ESLint configurations. Said error can be overridden by setting the "allowShortCircuit" option to "true" on .eslintrc, but since current guidelines don't recommend it, such cases should be avoided as much as possible, hence the change.