Repository navigation
Conversation
`TesseractDecoder.decode_batch` and `SimplexDecoder.decode_batch` held the GIL for the whole batch, so no other Python thread could run until they returned. That stalls threads that have to keep running while a batch decodes, e.g. the Pub/Sub client's lease manager in a worker that pulls batches from a queue: when it can't renew the lease in time, the batch is redelivered to another worker while it is still being decoded. The decoding loop touches no Python objects, so release the GIL while it runs. The new test checks that a countdown thread finishes while `decode_batch` decodes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TesseractDecoder.decode_batchandSimplexDecoder.decode_batchheld the GIL for the whole batch, so no other Python thread could run until they returned. That stalls threads that have to keep running while a batch decodes, e.g. a Pub/Sub client's lease manager in a worker that pulls batches from a queue: when it can't renew the lease in time, the batch is redelivered to another worker while it is still being decoded (this is my actual use case -- I am running tesseract's pybind interface in a cloud worker pool.)The decoding loop touches no Python objects, so release the GIL while it runs. The new test checks that a countdown thread finishes while
decode_batchdecodes.