Specs clarification: Forbid ClassVar and Final within TypedDict body#1890
Merged
carljm merged 4 commits intopython:mainfrom Dec 8, 2024
InSyncWithFoo:main
Merged
Specs clarification: Forbid ClassVar and Final within TypedDict body#1890carljm merged 4 commits intopython:mainfrom InSyncWithFoo:main
ClassVar and Final within TypedDict body#1890carljm merged 4 commits intopython:mainfrom
InSyncWithFoo:main
Conversation
Member
|
I'd prefer to approach this by being precise about where |
5 tasks
erictraut
reviewed
Dec 1, 2024
erictraut
approved these changes
Dec 1, 2024
carljm
approved these changes
Dec 2, 2024
JukkaL
approved these changes
Dec 2, 2024
rchen152
approved these changes
Dec 2, 2024
JelleZijlstra
approved these changes
Dec 2, 2024
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
I feel this could still be phrased in a more general way, but we can change that later.
Contributor
Author
|
Is there anything else need to be done here? |
carljm
added a commit
to erictraut/typing
that referenced
this pull request
Jan 9, 2025
* main: (29 commits) Updated conformance test results for the latest versions of type chec… (python#1904) Add content from typeshed/CONTRIBUTING.md (python#1882) Fix markup in generics specification (python#1900) Specs clarification: Forbid `ClassVar` and `Final` within `TypedDict` body (python#1890) Remove paragraph mentioning minor edits through the mailing list (python#1891) Writing Stubs: Add "Overloads and Flags" section (python#1894) Fix a typo (python#1893) Update conformance tests for recent generics spec change (python#1892) Clarify some behavior around user-defined generic classes (python#1879) Modernizing guide: Mention TypeGuard/TypeIs (python#1887) Tools can perform "some" refactorings (python#1886) Mention use of cast in enum type stub example (python#1877) Update conformance results after new pyre release (python#1878) Add a label for typed dictionaries class-based syntax (python#1873) Add missing return type to generic_syntax_infer_variance.py (python#1871) Updated conformance results for mypy 1.13 and pyright 1.1.386 (python#1870) Modernizing guide: also mention `com2ann` (python#1869) Suggest `pyupgrade` or `ruff` for modernizing superseded typing features (python#1868) Updated conformance results for pyright 1.1.385. (python#1867) Updated conformance results for mypy 1.12. (python#1866) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypedDictto have aClassVarfield?ClassVarandFinalwithinTypedDictAt runtime, both
ClassVarandFinalare not recognized as valid qualifiers forTypedDictitems: