-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
gh-96894: Do not turn echo off for subsequent commands in batch activators #96895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This seems a bit brittle (e.g. if new lines are added) - can't the echo be turned off and then back on at exit points, rather than almost every line being changed? |
Unfortunately, there's no reasonable way to restore the caller's setting when you're done (yeah, batch is crap): |
@vsajip ping :) |
@python/windows-team |
@vsajip ping again! Please approve, assign a different reviewer, or let me know what you would like me to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Leaving for @vsajip to merge/object
Some
@
are certainly unnecessary but I don't feel confident enough to optimize.Closes #96894