Skip to content

gh-96894: Do not turn echo off for subsequent commands in batch activators #96895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pawelszramowski
Copy link

@pawelszramowski pawelszramowski commented Sep 17, 2022

Some @ are certainly unnecessary but I don't feel confident enough to optimize.

Closes #96894

@ghost
Copy link

ghost commented Sep 17, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@vsajip
Copy link
Member

vsajip commented Sep 18, 2022

This seems a bit brittle (e.g. if new lines are added) - can't the echo be turned off and then back on at exit points, rather than almost every line being changed?

@pawelszramowski
Copy link
Author

Unfortunately, there's no reasonable way to restore the caller's setting when you're done (yeah, batch is crap):

@pawelszramowski
Copy link
Author

@vsajip ping :)

@arhadthedev
Copy link
Member

@python/windows-team

@pawelszramowski
Copy link
Author

@vsajip ping again! Please approve, assign a different reviewer, or let me know what you would like me to change.

Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Leaving for @vsajip to merge/object

@python-cla-bot
Copy link

python-cla-bot bot commented Apr 18, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch activators unexpectedly turn echo off for subsequent commands
5 participants