Skip to content

[3.7] gh-93065: Fix HAMT to iterate correctly over 7-level deep trees (GH-93066) #93149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022

Conversation

ambv
Copy link
Contributor

@ambv ambv commented May 23, 2022

Also while there, clarify a few things about why we reduce the hash to 32 bits.

Co-authored-by: Eli Libman eli@hyro.ai
Co-authored-by: Yury Selivanov yury@edgedb.com
Co-authored-by: Łukasz Langa lukasz@langa.pl

(cherry picked from commit c1f5c90)

… trees (pythonGH-93066)

Also while there, clarify a few things about why we reduce the hash to 32 bits.

Co-authored-by: Eli Libman <eli@hyro.ai>
Co-authored-by: Yury Selivanov <yury@edgedb.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
(cherry picked from commit c1f5c90)

Co-authored-by: Yury Selivanov <yury@edgedb.com>
@ambv
Copy link
Contributor Author

ambv commented May 23, 2022

@ned-deily, this goes to 3.7 as well because it's a potential crashes (and so a DoS issue).

@ned-deily ned-deily merged commit 3a4ca49 into python:3.7 May 23, 2022
@ned-deily
Copy link
Member

Thanks, @ambv, for the backport.

@ambv ambv deleted the backport-c1f5c90-3.7 branch May 24, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants