-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Minor: fix unicode-related inline function warnings #93011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
@bedevere-bot (This issue seems too minor to warrant an issue number or a NEWS entry) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! cc @vstinner who worked on this file recently.
I think we can skip the news entry here because the problem it fixes hasn't been in any release (it's in the main branch only). If it had been in a release, we should have added a NEWS entry because it's a user-visible change.
I'll leave this open for a few days in case Victor or others have comments, and then merge.
(Commit amended with tweaked syntax) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merged, thanks. |
When compiling my extension module against latest
main
version of CPython, I get many warnings related to unused parameters inunicodeobject.h
. Example:This PR fixes those warnings. This isn't really a bug in Python, so I did not create a corresponding issue tracker ticket.