Repository navigation
bpo-43225: [DOC] Add missing value returned by methods on cookiejar - #24522
Merged
Merged
Conversation
Documentation say that return something but don't specific with what value is return, and that can be confuse. This patch add that information.
Contributor
Author
|
Re open to know if the tests pass |
eamanu
changed the title
|
This PR is stale because it has been open for 30 days with no activity. |
akulakov
requested changes
Jul 7, 2021
akulakov
left a comment
akulakov
left a comment
Contributor
There was a problem hiding this comment.
Thanks!, - this is a good change that makes return value much clearer. Requesting a small change because 'whether' would not be gramatically correct to leave in with this change.
Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
Contributor
Author
|
Thanks @akulakov |
willingc
approved these changes
Nov 15, 2021
remykarem
pushed a commit
to remykarem/cpython
that referenced
this pull request
Dec 7, 2021
…ythonGH-24522) * Add missing value returned by methods on cookiejar Documentation say that return something but don't specific with what value is return, and that can be confuse. This patch add that information. * Update Doc/library/http.cookiejar.rst Co-authored-by: andrei kulakov <andrei.avk@gmail.com> * Update Doc/library/http.cookiejar.rst Co-authored-by: andrei kulakov <andrei.avk@gmail.com> Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation say that return something but don't specific with what
value is return, and that can be confuse. This patch add that information.
https://bugs.python.org/issue43225