Skip to content

Fix id of 'Internet Message Format' RFC in email doc - #24137

Merged
orsenthil merged 1 commit into
python:masterfrom
dlax:docs/fix-email-rfc
Apr 26, 2021
Merged

Fix id of 'Internet Message Format' RFC in email doc#24137
orsenthil merged 1 commit into
python:masterfrom
dlax:docs/fix-email-rfc

Conversation

@dlax

@dlax dlax commented Jan 6, 2021

Copy link
Copy Markdown
Contributor

Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5232 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0#diff-7728cd0eb5e471a8d52c0850e26560351f50ec6cb59d03bd5646bf492d80eb24 in which the ID of
this RFC got updated from the obsolete 2822.)

@dlax
dlax requested a review from a team as a code owner January 6, 2021 08:46
@the-knights-who-say-ni

the-knights-who-say-ni commented Jan 6, 2021

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dlax

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 6, 2021
serverwentdown
serverwentdown suggested changes Feb 11, 2021
View reviewed changes

@serverwentdown serverwentdown left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this typo has been around for 5 years. Nice find!

There is also one more occurrence in email.compat32-message.rst, that should probably be updated too.

Comment thread Doc/library/email.rst Outdated
@dlax @serverwentdown
Fix id of 'Internet Message Format' RFC in email doc
55a20a7 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <ambrose@hey.com>
@dlax
dlax force-pushed the docs/fix-email-rfc branch from a9ebee9 to 55a20a7 Compare February 11, 2021 10:49
serverwentdown
serverwentdown approved these changes Feb 11, 2021
View reviewed changes

@serverwentdown serverwentdown left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now links to the correct RFC.

@github-actions

github-actions Bot commented Mar 14, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Mar 14, 2021
@orsenthil
orsenthil merged commit cb5c802 into python:master Apr 26, 2021
@miss-islington

miss-islington commented Apr 26, 2021

Copy link
Copy Markdown
Contributor

Thanks @dlax for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@dlax @miss-islington
Fix id of 'Internet Message Format' RFC in email doc (pythonGH-24137)
e5d17ca 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <ambrose@hey.com>
(cherry picked from commit cb5c802)

Co-authored-by: Denis Laxalde <denis@laxalde.org>
@bedevere-bot

bedevere-bot commented Apr 26, 2021

Copy link
Copy Markdown

GH-25613 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@dlax @miss-islington
Fix id of 'Internet Message Format' RFC in email doc (pythonGH-24137)
9dbc9e8 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <ambrose@hey.com>
(cherry picked from commit cb5c802)

Co-authored-by: Denis Laxalde <denis@laxalde.org>
@bedevere-bot

bedevere-bot commented Apr 26, 2021

Copy link
Copy Markdown

GH-25614 is a backport of this pull request to the 3.8 branch.

@dlax
dlax deleted the docs/fix-email-rfc branch April 26, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orsenthil orsenthil orsenthil approved these changes
+1 more reviewer
@serverwentdown serverwentdown serverwentdown approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dlax @the-knights-who-say-ni @miss-islington @bedevere-bot @orsenthil @serverwentdown @tirkarthi