Skip to content

bpo-39094: Add a default to statistics.mean and related functions - #17657

Closed
yoniLavi wants to merge 1 commit into
python:masterfrom
yoniLavi:mean
Closed

bpo-39094: Add a default to statistics.mean and related functions#17657
yoniLavi wants to merge 1 commit into
python:masterfrom
yoniLavi:mean

Conversation

@yoniLavi

@yoniLavi yoniLavi commented Dec 19, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

bpo-39094: Add a default to statistics.mean and related functions

This pull request provides an example python-based implementation of a default parameter to the mean, fmean, geometric_mean and harmonic_mean functions in the statistics module.

https://bugs.python.org/issue39094

@yoniLavi yoniLavi changed the title Add a default kw-only argument to mean functions bpo-39094: Add a default to statistics.mean and related functions Dec 19, 2019
taleinat
taleinat reviewed Dec 19, 2019
View reviewed changes

@taleinat taleinat left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using None for the default should certainly be supported. This needs to use a different mechanism to detect whether a default value was provided. For example, a custom sentinel value, e.g. _NO_DEFAULT = object(), would do.

@csabella

csabella commented May 22, 2020

Copy link
Copy Markdown
Contributor

Thank you for your work on this, but I'm going to close this PR as the issue on the bug tracker was rejected.

@csabella csabella closed this May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taleinat taleinat taleinat left review comments

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yoniLavi @csabella @taleinat @the-knights-who-say-ni @bedevere-bot