Repository navigation
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On POSIX,
spawnandforkserverworkers must receive internal pipe and resource-tracker descriptors across the initial exec, but those descriptors should not remain inheritable when the worker launches its own subprocesses. The current behavior can keep a parent process blocked waiting for EOF or for a worker to join.This patch marks the handed-off descriptors non-inheritable as soon as the worker starts, covers the POSIX
spawn_mainsentinel and resource tracker, and preventsForkServer's passed descriptors and detached connection descriptors from leaking. It preserves the descriptors for the initial process start and closes them to subsequent execs; no multiprocessing API is changed.Regression coverage
Adds a multiprocessing regression that checks the descriptor inheritance flags in
spawnandforkserverchild processes, using realPipeconnections and the resource-tracker/forkserver descriptors. The earlier isolated development build and relevant multiprocessing tests passed; this is a carried-forward implementation from branchgpt6-c6e21/mp-fd-cloexec(tipc07b384).AI disclosure
This patch was authored and tested with autonomous GPT-6 assistance. The presenting agent reviewed the issue and code changes, including Windows default argument compatibility and POSIX CLOEXEC behavior. No claim of human review is made.
Fixes #161408.