Repository navigation
gh-158798: Replace misleading "hashable collections" in object.__hash… - #162077
Open
themythofsisyphusjayant wants to merge 1 commit into
Open
themythofsisyphusjayant wants to merge 1 commit into
themythofsisyphusjayant wants to merge 1 commit into
Conversation
themythofsisyphusjayant
requested review from
AA-Turner and
willingc
as code owners
November 16, 2026 02:53
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
object.__hash__docs said instances "will not be usable as items in hashable collections" and that "the implementation ofhashablecollections requires that a key's hash value is immutable". The glossary defines "hashable" as a property of an object, so "hashable collections" reads as "collections that can be hashed" — butsetanddictare not hashable in that sense. What is meant is collections that use hashing internally.This rewords both spots in
Doc/reference/datamodel.rstto "collections ofhashableobjects", keeping the glossary link (as requested in the issue discussion). The first paragraph's "hashed collections" is left unchanged.Checked by building the page with Sphinx (9.1.1, from
Doc/requirements.txt): the page renders with the new wording at both spots and the old phrase nowhere. The only build warnings are pre-existing single-file-build artifacts, identical before and after the change.Disclosure: I used an AI coding assistant to help prepare this change, and reviewed the diff myself before submitting.
object.__hash__documentation is misleading #158798