gh-150732: Handle SystemError from compiler in the REPLs - #151480
Open
johnslavik wants to merge 4 commits into
Open
johnslavik wants to merge 4 commits into
johnslavik wants to merge 4 commits into
Conversation
johnslavik
added
needs backport to 3.14
| compiler(source + "\n", filename, symbol, flags=flags) | ||
| return None | ||
| except _IncompleteInputError: | ||
| except _IncompleteInputError, SystemError: |
Member
There was a problem hiding this comment.
Won't this just hide a SystemError?
| @@ -147,8 +147,8 @@ def __call__(self, source, filename="<input>", symbol="single"): | |||
|
|
|||
| - Return a code object if the command is complete and valid | |||
| - Return None if the command is incomplete | |||
Member
There was a problem hiding this comment.
But we return None, no? Also, this docstring is repeated in several places, all of them would need updating.
johnslavik
commented
Jun 24, 2026
johnslavik
left a comment
johnslavik
left a comment
Member
Author
There was a problem hiding this comment.
This doesn't cover pdb. Currently, pdb will run into postmortem from the failing compilation of prompt.
|
This PR is stale because it has been open for 90 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try
>>> class C: [(lambda: __class__)() for () in ()]at rev 5804991 or earlier as the prompt to reproduce organically at upstream.This covers cases in our REPLs when the compiler raises
SystemError, e.g. because it has a bug.SystemErrorfrom the compiler #150732