gh-132629: Deprecate acception out of range values for unsigned integers in PyArg_Parse #132630
+647
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… integers in PyArg_Parse For unsigned integer formats in the PyArg_Parse* funcions, accepting Python integers with value that is larger than the maximal value the corresponding C type or less than the minimal value for the corresponding signed integer type is now deprecated.
serhiy-storchaka
requested review from
erlend-aasland and
a team
as code owners
vstinner
reviewed
Apr 23, 2025
Modules/fcntlmodule.c
Outdated
| #ifndef Py_GIL_DISABLED | ||
| # define Py_LIMITED_API 0x030d0000 | ||
| #ifndef Py_BUILD_CORE_BUILTIN | ||
| # define Py_BUILD_CORE_MODULE 1 |
There was a problem hiding this comment.
You may be able to continue using the limited C API, since PyLong_AsNativeBytes() was added to the limited C API: #132640
vstinner
reviewed
Apr 23, 2025
|
This is not a blocker. But the sooner we add warnings, the sooner we can turn them into errors. Recently, you and me added many uses of unsigned integer converters in the socket addresses parsing code. This fixed errors, and allowed to pass values that exceed the limit of corresponding signed integer type, but made the new code more error prone, because passing value that exceeds the limit of an unsigned integer type does not lead to exception. This is the main reason I created that PR now. The idea I proposed a year ago: capi-workgroup/api-evolution#49. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unsigned integer formats in the PyArg_Parse* funcions, accepting Python integers with value that is larger than the maximal value the corresponding C type or less than the minimal value for the corresponding signed integer type is now deprecated.
📚 Documentation preview 📚: https://cpython-previews--132630.org.readthedocs.build/