GH-92584: Remove references to Distutils in configure.rst #108043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
docs
AA-Turner
commented
Aug 16, 2023
Comment on lines
781
to
783
| Both :envvar:`CPPFLAGS` and :envvar:`LDFLAGS` need to contain the shell's | ||
| value for setup.py to be able to build extension modules using the | ||
| value to be able to build extension modules using the | ||
| directories specified in the environment variables. |
There was a problem hiding this comment.
I've just removed setup.py rather than replacing with e.g. Makefile as I believe CPPFLAGS and LDFLAGS are used by the windows build, though I'm not sure.
Comment on lines
+819
to
+820
| extensions. Use it when a compiler flag should *not* be part of | ||
| :envvar:`CFLAGS` once Python is installed (:gh:`65320`). |
There was a problem hiding this comment.
I'm not sure if the issue link (#65320) is still relevant, but I've kept in case.
|
Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Merged, thanks. |
|
GH-108063 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 16, 2023
…onGH-108043) Remove references to Distutils in configure.rst (cherry picked from commit e88eb37) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.pywas removed in #94474.📚 Documentation preview 📚: https://cpython-previews--108043.org.readthedocs.build/