Wrap unused arguments in Objects/obmalloc.c with `Py_UNUSED`.

[zikcheng]

As the title says, parameter ctx is not used in body of function pymalloc_alloc and pymalloc_free.

[erlend-aasland]

You'll find there's a lot of unused arguments in the CPython code base. We could wrap these two in Py_UNUSED, but there would be a lot left, so I don't see a particular reason to just change these two.

Suggesting to close this.

[erlend-aasland]

cc. @vstinner

[erlend-aasland]

FTR:

cpython/Objects/obmalloc.c

Lines 1947 to 1948 in e5d8dbd

	static inline void*
	pymalloc_alloc(void *ctx, size_t nbytes)

cpython/Objects/obmalloc.c

Lines 2217 to 2218 in e5d8dbd

	static inline int
	pymalloc_free(void *ctx, void *p)

[erlend-aasland]

The following functions in obmalloc.c have one or more unused arguments:

• _PyMem_RawMalloc
• _PyMem_RawCalloc
• _PyMem_RawRealloc
• _PyMem_RawFree
• _PyObject_ArenaVirtualAlloc
• _PyObject_ArenaVirtualFree
• _PyObject_ArenaMmap
• _PyObject_ArenaMunmap
• _PyObject_ArenaMalloc
• _PyObject_ArenaFree
• address_in_range
• pymalloc_alloc
• pymalloc_free

Victor says he's +1 on wrapping unused arguments with Py_UNUSED.

[zikcheng]

Why wrapping instead of removing, is it a convention?

[vstinner]

Why wrapping instead of removing, is it a convention?

The ctx parameter is part of PEP 445 API.

[kumaraditya303]

Fixed by #93175